Skip to content

Improve AssemblyLoadContext documentation #2833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2019
Merged

Improve AssemblyLoadContext documentation #2833

merged 1 commit into from
Jul 26, 2019

Conversation

MSDN-WhiteKnight
Copy link
Contributor

Summary

  • Fix LoadUnmanagedDll return value. IntPtr is a value type and can't be null.
  • Add missing method descriptions.

@MSDN-WhiteKnight
Update AssemblyLoadContext.xml
7e876ff 
- Fix AssemblyLoadContext.LoadUnmanagedDll return value. IntPtr is a value type and can't be null.
- Add missing property descriptions.
@rpetrusha rpetrusha added this to the July 2019 milestone Jul 26, 2019
@rpetrusha
Copy link

@sdmaclea, could you review the SetProfileOptimization and SetProfileOptimizationRoot methods, please?

@rpetrusha
Copy link

Thanks for submitting this PR, @MSDN-WhiteKnight. It looks really good, although I'd like @sdmaclea to take a look as well.

@mairaw mairaw added the waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews label Jul 26, 2019
@mairaw mairaw requested a review from sdmaclea July 26, 2019 17:58
sdmaclea
sdmaclea approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@sdmaclea sdmaclea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sdmaclea sdmaclea removed the waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews label Jul 26, 2019
@sdmaclea sdmaclea merged commit e0920d1 into dotnet:master Jul 26, 2019
@MSDN-WhiteKnight MSDN-WhiteKnight deleted the patch-1 branch July 27, 2019 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sdmaclea sdmaclea sdmaclea approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@MSDN-WhiteKnight MSDN-WhiteKnight

Labels
None yet
Projects
None yet
Milestone
July 2019
Development

Successfully merging this pull request may close these issues.
4 participants
@MSDN-WhiteKnight @rpetrusha @sdmaclea @mairaw