Skip to content

Use "When overridden" on AsymmetricAlgorithm virtual+throws #2861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2019
Merged

Use "When overridden" on AsymmetricAlgorithm virtual+throws #2861

merged 1 commit into from
Jul 30, 2019
+47 −10

Conversation

bartonjs
Copy link
Member

Summary

Corrects new documentation for AsymmetricAlgorithm key import/export methods, as their implementation is to throw an exception that an override is required.

Fixes #Issue_Number (if available)

@rpetrusha rpetrusha added this to the August 2019 milestone Jul 30, 2019
@Thraka Thraka self-requested a review July 30, 2019 15:57
rpetrusha
rpetrusha approved these changes Jul 30, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these enhancements, @bartonjs. I'll merge your PR now.

@rpetrusha rpetrusha merged commit 11db183 into dotnet:master Jul 30, 2019
@Thraka Thraka removed their request for review July 30, 2019 15:59
@bartonjs bartonjs deleted the asymm_key_corrections branch November 23, 2019 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bartonjs bartonjs

Labels

None yet

Projects

None yet

Milestone

August 2019

Development

Successfully merging this pull request may close these issues.

2 participants

@bartonjs @rpetrusha