fix cdata formatting #2893
Merged
fix cdata formatting #2893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mairaw no, on the contrary, my tool has been fixing these. If you look at my latest batch of Json PRs, my tool made the same fixes you made here. Which leads me to think that the files get bad at some point after I submit my PR. |
|
Update: Apparently my tool did this. The PR that had all these System.Text.Json comments was submitted many weeks ago, back when this bug was not fixed yet. I got the issue fixed in my tool a couple of weeks ago (when we were first notified by the Loc team about this problem). I'll double check my recent Json PRs to make sure we don't do the same issue. |
|
Great, thanks @carlossanlop! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a few more. I'm wondering if this the porting tool that is doing this formatting @carlossanlop?