Skip to content

Dev/suwhang/system.diagnostics #2901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 7, 2019
Merged

Dev/suwhang/system.diagnostics #2901

merged 12 commits into from
Aug 7, 2019

Conversation

sywhang
Copy link
Contributor

@sywhang sywhang commented Aug 1, 2019 •
edited
Loading

System.Diagnostics API docs update for 3.0.

cc @tommcdon @noahfalk @carlossanlop @mariaw @rpetrusha

@carlossanlop carlossanlop added 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews labels Aug 1, 2019
@carlossanlop carlossanlop added this to the August 2019 milestone Aug 1, 2019
carlossanlop
carlossanlop reviewed Aug 1, 2019
View reviewed changes
carlossanlop
carlossanlop reviewed Aug 1, 2019
View reviewed changes
carlossanlop
carlossanlop reviewed Aug 1, 2019
View reviewed changes
carlossanlop
carlossanlop reviewed Aug 1, 2019
View reviewed changes
carlossanlop
carlossanlop reviewed Aug 1, 2019
View reviewed changes
@rpetrusha
Copy link

I've fixed three XML errors reported by the build.

carlossanlop
carlossanlop reviewed Aug 1, 2019
View reviewed changes
carlossanlop
carlossanlop reviewed Aug 1, 2019
View reviewed changes
carlossanlop
carlossanlop reviewed Aug 1, 2019
View reviewed changes
carlossanlop
carlossanlop reviewed Aug 1, 2019
View reviewed changes
carlossanlop
carlossanlop reviewed Aug 1, 2019
View reviewed changes
carlossanlop
carlossanlop reviewed Aug 1, 2019
View reviewed changes
carlossanlop
carlossanlop suggested changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @sywhang . I left a few suggestions. Please wait for @mairaw / @rpetrusha to review the PR too.

@carlossanlop carlossanlop removed the waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews label Aug 1, 2019
rpetrusha
rpetrusha suggested changes Aug 2, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some suggestions and comments, @sywhang. Also, there were a number of cases where elements were removed. I think that I caught them all, but it would be good if you could double-check to make sure that all of them are restored.

@carlossanlop carlossanlop added the changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review label Aug 6, 2019
@carlossanlop
Copy link
Contributor

@rpetrusha can you please take a look at this PR once more? @sywhang addressed all the suggestions and the build passed.

@carlossanlop carlossanlop self-assigned this Aug 7, 2019
@carlossanlop
Copy link
Contributor

@rpetrusha @sywhang I moved the text Ron suggested to move from the Constructor remarks to the Type remarks. Can you please take a look? Aside from that, I think everything else has been addressed.

@sywhang
Copy link
Contributor Author

sywhang commented Aug 7, 2019

Thanks @carlossanlop - It looks fine to me!

@carlossanlop carlossanlop added verify-build-before-merge and removed changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review labels Aug 7, 2019
@rpetrusha
Copy link

This looks good aside from broken crefs, which I've fixed. After the build completes, this should be ready to merge. Do you want to take a look and approve, @carlossanlop?

carlossanlop
carlossanlop approved these changes Aug 7, 2019
View reviewed changes
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpetrusha Thank you for fixing the broken refs. The changes look good. Approving.

@rpetrusha
Copy link

The build has passed, so I'll merge now. Thanks, @sywhang and @carlossanlop!

@rpetrusha rpetrusha merged commit 9eeeaef into dotnet:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tommcdon tommcdon tommcdon approved these changes

@mairaw mairaw Awaiting requested review from mairaw

@noahfalk noahfalk Awaiting requested review from noahfalk

+2 more reviewers

@carlossanlop carlossanlop carlossanlop approved these changes

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carlossanlop carlossanlop

@sywhang sywhang

Labels

🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles

Projects

None yet

Milestone

August 2019

Development

Successfully merging this pull request may close these issues.

5 participants

@sywhang @rpetrusha @carlossanlop @tommcdon @mairaw