Document Json namespaces #2906
Merged
Document Json namespaces #2906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
added
new-content
carlossanlop
requested review from
ahsonkhan,
steveharter,
rpetrusha and
mairaw
rpetrusha
reviewed
Aug 1, 2019
There was a problem hiding this comment.
Thanks for remembering that this needs to be done, @ahsonkhan, and for opening the PR, @carlossanlop. I've left a couple of suggestions.
Co-Authored-By: Ron Petrusha <[email protected]>
ahsonkhan
reviewed
Aug 1, 2019
ahsonkhan
approved these changes
Aug 1, 2019
I merely helped wordsmith the description for the namespaces. @carlossanlop actually detected and brought this up as missing doc. Thanks for addressing this! I appreciate your effort and help getting S.T.Json documented overall. |
Co-Authored-By: Ahson Khan <[email protected]>
carlossanlop
added
changes-addressed
mairaw
removed
verify-build-before-merge
changes-addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @ahsonkhan