Skip to content

Document Json namespaces #2906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 2, 2019
Merged

Document Json namespaces #2906

merged 3 commits into from
Aug 2, 2019

Conversation

carlossanlop
Copy link
Contributor

As suggested by @ahsonkhan

@carlossanlop carlossanlop added new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 labels Aug 1, 2019
@carlossanlop carlossanlop added this to the August 2019 milestone Aug 1, 2019
@carlossanlop carlossanlop self-assigned this Aug 1, 2019
@carlossanlop carlossanlop requested a review from jozkee August 1, 2019 20:45
rpetrusha
rpetrusha reviewed Aug 1, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for remembering that this needs to be done, @ahsonkhan, and for opening the PR, @carlossanlop. I've left a couple of suggestions.

@carlossanlop
suggestions by rpetrusha
911efda 
Co-Authored-By: Ron Petrusha <[email protected]>
ahsonkhan
ahsonkhan reviewed Aug 1, 2019
View reviewed changes
ahsonkhan
ahsonkhan approved these changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@ahsonkhan ahsonkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the small fix. LGTM.

@ahsonkhan
Copy link
Contributor

Thanks for remembering that this needs to be done, @ahsonkhan, and for opening the PR, @carlossanlop

I merely helped wordsmith the description for the namespaces. @carlossanlop actually detected and brought this up as missing doc. Thanks for addressing this! I appreciate your effort and help getting S.T.Json documented overall.

@carlossanlop @ahsonkhan
suggestion by ahsonkhan
3e49dcb 
Co-Authored-By: Ahson Khan <[email protected]>
@carlossanlop carlossanlop added changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review verify-build-before-merge and removed waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews labels Aug 2, 2019
mairaw
mairaw approved these changes Aug 2, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mairaw mairaw merged commit 5c19ace into dotnet:master Aug 2, 2019
@mairaw mairaw removed verify-build-before-merge changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review labels Aug 2, 2019
@carlossanlop carlossanlop deleted the JsonNamespaces branch September 22, 2020 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw mairaw approved these changes

@steveharter steveharter Awaiting requested review from steveharter

@jozkee jozkee Awaiting requested review from jozkee

+2 more reviewers

@rpetrusha rpetrusha rpetrusha left review comments

@ahsonkhan ahsonkhan ahsonkhan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@carlossanlop carlossanlop

Labels
🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles
Projects
None yet
Milestone
August 2019
Development

Successfully merging this pull request may close these issues.
4 participants
@carlossanlop @ahsonkhan @rpetrusha @mairaw