Skip to content

Conversation

carlossanlop
Copy link
Contributor

I got it from this JSON file:
https://github.com/dotnet/corefx/blob/83143cd0170770997a83b6543e406b5bf0db7d0a/pkg/descriptions.json#L1439

I'll add an issue in the DocsPortingTool: We could automate the extraction of namespaces from this file.

@carlossanlop carlossanlop added new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 labels Aug 1, 2019
@carlossanlop carlossanlop added this to the August 2019 milestone Aug 1, 2019
@carlossanlop carlossanlop self-assigned this Aug 1, 2019
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlossanlop
Copy link
Contributor Author

@mairaw The changes look good and the build passed. I think it's ready to get merged.

@carlossanlop carlossanlop added verify-build-before-merge and removed waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews labels Aug 2, 2019
@mairaw mairaw merged commit cf3cd4a into dotnet:master Aug 2, 2019
@carlossanlop carlossanlop deleted the ResourcesExtensionsNamespace branch September 15, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants