Skip to content

Conversation

bartonjs
Copy link
Member

@bartonjs bartonjs commented Aug 4, 2019

Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, @bartonjs. I just have two suggestions for property names that could be qualified with their type name.

@rpetrusha rpetrusha added this to the August 2019 milestone Aug 5, 2019
@carlossanlop carlossanlop added 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles labels Aug 5, 2019
@rpetrusha
Copy link

Thanks, @bartonjs. I'll merge this PR now.

@rpetrusha rpetrusha merged commit e1007c7 into dotnet:master Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants