Skip to content

Add documentation for the rest of the Pkcs12SafeBag derived types #2926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2019
Merged

Add documentation for the rest of the Pkcs12SafeBag derived types #2926

merged 2 commits into from
Aug 5, 2019

Conversation

bartonjs
Copy link
Member

@bartonjs bartonjs commented Aug 4, 2019

rpetrusha
rpetrusha suggested changes Aug 5, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, @bartonjs. I just have two suggestions for property names that could be qualified with their type name.

@rpetrusha rpetrusha added this to the August 2019 milestone Aug 5, 2019
@carlossanlop carlossanlop added 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles labels Aug 5, 2019
@rpetrusha
Copy link

Thanks, @bartonjs. I'll merge this PR now.

@rpetrusha rpetrusha merged commit e1007c7 into dotnet:master Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw Awaiting requested review from mairaw

1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@bartonjs bartonjs

Labels
🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles
Projects
None yet
Milestone
August 2019
Development

Successfully merging this pull request may close these issues.
3 participants
@bartonjs @rpetrusha @carlossanlop