Document Pkcs8PrivateKeyInfo #2932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
added
🏁 Release: .NET Core 3.0
rpetrusha
suggested changes
Aug 6, 2019
| <param name="algorithmId">The Object Identifier (OID) identifying the asymmetric algorithm this key is for.</param> | ||
| <param name="algorithmParameters">The BER-encoded algorithm parameters associated with this key, or <see langword="null"/> to omit algorithm parameters when encoding.</param> | ||
| <param name="privateKey">The algorithm-specific encoded private key.</param> | ||
| <param name="skipCopy"><see langword="true"/> to store <paramref name="algorithmParameters"/> and <paramref name="privateKey"/> without making a defensive copy; otherwise, <see langword="false"/>. The default is <see langword="false"/>.</param> |
There was a problem hiding this comment.
The parameter name is shown in line 38 (and the original line 44) as skipCopies. Because of the disparity, the parameter description doesn't appear in the build.
There was a problem hiding this comment.
Whoops, copied and pasted from the only plural one :)
| When `pbeParameters` indicates an algorithm that uses PBKDF2 (Password-Based Key Derivation Function 2), the password is converted to bytes via the UTF-8 encoding. | ||
|
|
||
| ]]></format> | ||
| <altmember cref="Overload:System.Security.Cryptography.Pkcs.Pkcs8PrivateKeyInfo.TryEncrypt"/> |
There was a problem hiding this comment.
The <altmember> element should go after <remarks>, not before.
bartonjs
commented
Aug 7, 2019
bartonjs
commented
Aug 7, 2019
bartonjs
commented
Aug 7, 2019
Co-Authored-By: Ron Petrusha <[email protected]>
|
I think that successfully took all of the edits. |
mairaw
added
the
changes-addressed
|
Thanks for the additional changes, @bartonjs. I'll merge your PR now. |
rpetrusha
approved these changes
Aug 7, 2019
mairaw
removed
waiting-on-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @carlossanlop