Skip to content

Added documentation for System.Numerics.Complex APIs targeted for 3.0 #2946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 6, 2019
Merged

Added documentation for System.Numerics.Complex APIs targeted for 3.0 #2946

merged 4 commits into from
Aug 6, 2019

Conversation

jozkee
Copy link
Member

@jozkee jozkee commented Aug 6, 2019

Docuented APIs:

  • System.Numerics.Complex.Add(System.Numerics.Complex,System.Double)
  • System.Numerics.Complex.Add(System.Double,System.Numerics.Complex)
  • System.Numerics.Complex.Divide(System.Numerics.Complex,System.Double)
  • System.Numerics.Complex.Divide(System.Double,System.Numerics.Complex)
  • System.Numerics.Complex.Infinity
  • System.Numerics.Complex.IsFinite(System.Numerics.Complex)
  • System.Numerics.Complex.IsInfinity(System.Numerics.Complex)
  • System.Numerics.Complex.IsNaN(System.Numerics.Complex)
  • System.Numerics.Complex.Multiply(System.Numerics.Complex,System.Double)
  • System.Numerics.Complex.Multiply(System.Double,System.Numerics.Complex)
  • System.Numerics.Complex.NaN

Notes:

@jozkee
Copy link
Member Author

jozkee commented Aug 6, 2019

@carlossanlop @mairaw @rpetrusha
@tannergooding

@carlossanlop carlossanlop added 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews labels Aug 6, 2019
@carlossanlop carlossanlop self-requested a review August 6, 2019 22:47
@carlossanlop carlossanlop added this to the August 2019 milestone Aug 6, 2019
carlossanlop
carlossanlop approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for fixing the already documented APIs, and the typo coming from my PR.
Let's wait and see if @rpetrusha @mairaw @tannergooding have any additional comments. Since this PR followed the same suggestions we used in my PR, I think we will be able to merge this quickly.

carlossanlop
carlossanlop reviewed Aug 6, 2019
View reviewed changes
carlossanlop
carlossanlop approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment that cased a build failure. Everything else seems fine.

rpetrusha
rpetrusha approved these changes Aug 6, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @jozkee. This can be merged when the build completes successfully.

@rpetrusha rpetrusha added verify-build-before-merge and removed waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews labels Aug 6, 2019
@mairaw mairaw merged commit 1d823f1 into dotnet:master Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw Awaiting requested review from mairaw

@tannergooding tannergooding Awaiting requested review from tannergooding

2 more reviewers

@carlossanlop carlossanlop carlossanlop approved these changes

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jozkee jozkee

Labels
🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles
Projects
None yet
Milestone
August 2019
Development

Successfully merging this pull request may close these issues.
4 participants
@jozkee @carlossanlop @rpetrusha @mairaw