Skip to content

Conversation

carlossanlop
Copy link
Contributor

This change has no ported triple slash comments.
Summaries have the special instructions enclosed by <param></para> to force adding an endline.
Descriptions at the end of the summaries were moved to the Remarks section.
No content changes, aside from a couple of extra sentence ending dots and spelling errors (intrinics -> intrinsic, or similar).

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great set of changes! Didn't review one by one but checked a few on review. Feel free to squash and merge when you're ready.

@mairaw mairaw added this to the September 2019 milestone Sep 5, 2019
Copy link

@CarolEidt CarolEidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also reviewed only a sampling, but it looks good.

Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same. LGTM

@carlossanlop carlossanlop added 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles verify-build-before-merge labels Sep 6, 2019
@carlossanlop
Copy link
Contributor Author

@mairaw @rpetrusha the build passed without warnings. If this looks good, can we please merge it?

@mairaw
Copy link
Contributor

mairaw commented Sep 6, 2019

I thought you had permissions. Merging now.

@mairaw mairaw merged commit 3e35e97 into dotnet:master Sep 6, 2019
@carlossanlop carlossanlop deleted the newIntrinsics branch November 6, 2019 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants