Skip to content

Automatically port Reflection.AssemblyHashAlgorithm #3183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 24, 2019
Merged

Automatically port Reflection.AssemblyHashAlgorithm #3183

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1126966
Automatically port Reflection.AssemblyHashAlgorithm
carlossanlop Sep 16, 2019
e18ccd9
Remove first line
carlossanlop Sep 16, 2019
4928bb6
suggestion by rpetrusha
carlossanlop Sep 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 32 additions & 8 deletions xml/System.Reflection/AssemblyHashAlgorithm.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<BaseTypeName>System.Enum</BaseTypeName>
</Base>
<Docs>
<summary>To be added.</summary>
<summary>Specifies the hash algorithms used for hashing assembly files and for generating the strong name.</summary>
<remarks>To be added.</remarks>
</Docs>
<Members>
Expand All @@ -44,8 +44,22 @@
</ReturnValue>
<MemberValue>32771</MemberValue>
<Docs>
<summary>To be added.</summary>
<remarks>Due to collision problems with MD5, Microsoft recommends SHA256.</remarks>
<summary>Retrieves the MD5 message-digest algorithm.</summary>
<remarks>
<format type="text/markdown">
<![CDATA[
## Remarks
> [!IMPORTANT]
> Due to collision problems with MD5, Microsoft recommends SHA256.
MD5 was developed by Rivest in 1991. It is basically MD4 with safety-belts and while it is slightly slower than MD4, it helps provide more security.
The algorithm consists of four distinct rounds, which has a slightly different design from that of MD4. Message-digest size, as well as padding requirements, remain the same.
]]></format>
</remarks>
</Docs>
</Member>
<Member MemberName="None">
Expand All @@ -70,7 +84,17 @@
</ReturnValue>
<MemberValue>0</MemberValue>
<Docs>
<summary>To be added.</summary>
<summary>A mask indicating that there is no hash algorithm.</summary>
<remarks>
<format type="text/markdown">
<![CDATA[
## Remarks
If you specify `None` for a multi-module assembly, the common language runtime defaults to the SHA1 algorithm, since multi-module assemblies need to generate a hash.
]]></format>
</remarks>
</Docs>
</Member>
<Member MemberName="Sha1">
Expand All @@ -95,7 +119,7 @@
</ReturnValue>
<MemberValue>32772</MemberValue>
<Docs>
<summary>To be added.</summary>
<summary>Retrieves a revision of the Secure Hash Algorithm that corrects an unpublished flaw in SHA.</summary>
<remarks>Due to collision problems with SHA1, Microsoft recommends SHA256.</remarks>
</Docs>
</Member>
Expand All @@ -121,7 +145,7 @@
</ReturnValue>
<MemberValue>32780</MemberValue>
<Docs>
<summary>To be added.</summary>
<summary>Retrieves a version of the Secure Hash Algorithm with a hash size of 256 bits.</summary>
</Docs>
</Member>
<Member MemberName="Sha384">
Expand All @@ -146,7 +170,7 @@
</ReturnValue>
<MemberValue>32781</MemberValue>
<Docs>
<summary>To be added.</summary>
<summary>Retrieves a version of the Secure Hash Algorithm with a hash size of 384 bits.</summary>
</Docs>
</Member>
<Member MemberName="Sha512">
Expand All @@ -171,7 +195,7 @@
</ReturnValue>
<MemberValue>32782</MemberValue>
<Docs>
<summary>To be added.</summary>
<summary>Retrieves a version of the Secure Hash Algorithm with a hash size of 512 bits.</summary>
</Docs>
</Member>
</Members>
Expand Down