Automatically port Data.DataRowView remark and exception #3186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
added
new-content
carlossanlop
requested review from
divega,
ajcvickers,
cheenamalhotra and
Gary-Zh
divega
approved these changes
Sep 16, 2019
rpetrusha
suggested changes
Sep 18, 2019
There was a problem hiding this comment.
I've left a suggestion and a comment, @carlossanlop. The build also failed for no apparent reason. Hopefully, it will build successfully after your next commit.
xml/System.Data/DataRowView.xml
Outdated
|
|
||
| Checks for same reference instead of equivalent <xref:System.Data.DataRowView.DataView> or <xref:System.Data.DataRowView.Row>. | ||
|
|
||
| Necessary for `ListChanged` event handlers to use data structures that use the default to <xref:System.Object.Equals(System.Object)> instead of <xref:System.Object.ReferenceEquals(System.Object,System.Object)> to understand if they need to add a <xref:E:System.Data.DataRowView.PropertyChanged> event handler. |
There was a problem hiding this comment.
This sentence (except it lacks a noun) makes no sense.
There was a problem hiding this comment.
Also sounds like an internal remark. I'll remove it.
Co-Authored-By: Ron Petrusha <[email protected]>
rpetrusha
approved these changes
Sep 26, 2019
|
This looks good, @carlossanlop. I'll merge it now. |
mairaw
removed
the
waiting-on-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Area owners: @divega, @ajcvickers,@cheenamalhotra, @David-Engel, @Gary-Zh