Automatically port Reflection.PortableExecutable.CodeViewDebugDirectoryData #3191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
added
new-content
carlossanlop
requested review from
GrabYourPitchforks,
steveharter,
rpetrusha and
mairaw
rpetrusha
suggested changes
Sep 25, 2019
There was a problem hiding this comment.
I've suggested some changes, @carlossanlop. But a type summary would also be useful. Could you add one? Something like, "Provides information about a Program Debug Database (PDB) file." And possibly a remark: "This structure is returned by a call to the <xref:System.Reflection.PortableExecutable.PEReader.ReadCodeViewDebugDirectoryData%2A?displayProperty=nameWithType> method."
xml/System.Reflection.PortableExecutable/CodeViewDebugDirectoryData.xml
Outdated
Show resolved
Hide resolved
xml/System.Reflection.PortableExecutable/CodeViewDebugDirectoryData.xml
Outdated
Show resolved
Hide resolved
xml/System.Reflection.PortableExecutable/CodeViewDebugDirectoryData.xml
Outdated
Show resolved
Hide resolved
Co-Authored-By: Ron Petrusha <[email protected]>
|
@rpetrusha thanks for the type summary and remark. I added them. @GrabYourPitchforks @steveharter can you please review this last commit? The type is not documented in code so I would like to make sure we're describing it accurately. |
|
Is this ready to merge, @carlossanlop? |
|
Yes, ready to merge @rpetrusha. |
carlossanlop
added
verify-build-before-merge
and removed
waiting-on-reviews
rpetrusha
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.