Automatically port Reflection.PortableExecutable.PdbChecksumDebugDirectoryData

[carlossanlop]

No description provided.

[rpetrusha]

I've left some suggestions for you to consider, @carlossanlop.

[carlossanlop]

@tmat would you mind helping us? Since you introduced this type, we need:

• A type summary. There isn't one in the source. I tried coming up with a description based on the text in the PR and the proposal, but I would prefer it the type creator gives us the most accurate description 😃
• Address @rpetrusha 's question about HashAlgorithmName: "is this a "checksum algorithm name" or a "checksum based on the algorithm name"?"

Here's the source: src/System.Reflection.Metadata/src/System/Reflection/PortableExecutable/DebugDirectory/PdbChecksumDebugDirectoryData.cs

Here's the PR that introduced: dotnet/corefx#26976

Here's the proposal (the text is the same as in the PR): https://github.com/dotnet/corefx/issues/26935

[tmat]

The type represents a PDB Checksum debug directory entry as specified here: https://github.com/dotnet/corefx/blob/master/src/System.Reflection.Metadata/specs/PE-COFF.md#pdb-checksum-debug-directory-entry-type-19.

This comment is incorrect. Should be "Checksum of the PDB content.".

[carlossanlop]

Thank you, @tmat for your quick help. I updated the PR with your suggestions. Let @rpetrusha and I know if you agree with the changes I made so we can merge this.

[sdmaclea]

LGTM

[rpetrusha]

Is this ready to merge, @carlossanlop?

[carlossanlop]

Yes, it's ready to merge, @rpetrusha.