Automatically port Reflection.PortableExecutable.DllCharacteristics #3195
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -49,7 +49,7 @@ | |||||
| </ReturnValue> | ||||||
| <MemberValue>4096</MemberValue> | ||||||
| <Docs> | ||||||
| <summary>The image must run inside an AppContainer.</summary> | ||||||
| </Docs> | ||||||
| </Member> | ||||||
| <Member MemberName="DynamicBase"> | ||||||
|
|
@@ -74,7 +74,7 @@ | |||||
| </ReturnValue> | ||||||
| <MemberValue>64</MemberValue> | ||||||
| <Docs> | ||||||
| <summary>DLL can move.</summary> | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| </Docs> | ||||||
| </Member> | ||||||
| <Member MemberName="HighEntropyVirtualAddressSpace"> | ||||||
|
|
@@ -98,7 +98,7 @@ | |||||
| </ReturnValue> | ||||||
| <MemberValue>32</MemberValue> | ||||||
| <Docs> | ||||||
| <summary>The image can handle a high entropy 64-bit virtual address space.</summary> | ||||||
| </Docs> | ||||||
| </Member> | ||||||
| <Member MemberName="NoBind"> | ||||||
|
|
@@ -123,7 +123,7 @@ | |||||
| </ReturnValue> | ||||||
| <MemberValue>2048</MemberValue> | ||||||
| <Docs> | ||||||
| <summary>Do not bind this image.</summary> | ||||||
| </Docs> | ||||||
| </Member> | ||||||
| <Member MemberName="NoIsolation"> | ||||||
|
|
@@ -148,7 +148,7 @@ | |||||
| </ReturnValue> | ||||||
| <MemberValue>512</MemberValue> | ||||||
| <Docs> | ||||||
| <summary>The image understands isolation and doesn't want it.</summary> | ||||||
| </Docs> | ||||||
| </Member> | ||||||
| <Member MemberName="NoSeh"> | ||||||
|
|
@@ -173,7 +173,7 @@ | |||||
| </ReturnValue> | ||||||
| <MemberValue>1024</MemberValue> | ||||||
| <Docs> | ||||||
| <summary>The image does not use SEH. No SE handler may reside in this image.</summary> | ||||||
| </Docs> | ||||||
| </Member> | ||||||
| <Member MemberName="NxCompatible"> | ||||||
|
|
@@ -198,7 +198,7 @@ | |||||
| </ReturnValue> | ||||||
| <MemberValue>256</MemberValue> | ||||||
| <Docs> | ||||||
| <summary>The image is NX compatible.</summary> | ||||||
| </Docs> | ||||||
| </Member> | ||||||
| <Member MemberName="ProcessInit"> | ||||||
|
|
@@ -223,7 +223,7 @@ | |||||
| </ReturnValue> | ||||||
| <MemberValue>1</MemberValue> | ||||||
| <Docs> | ||||||
| <summary>Reserved.</summary> | ||||||
| </Docs> | ||||||
| </Member> | ||||||
| <Member MemberName="ProcessTerm"> | ||||||
|
|
@@ -248,7 +248,7 @@ | |||||
| </ReturnValue> | ||||||
| <MemberValue>2</MemberValue> | ||||||
| <Docs> | ||||||
| <summary>Reserved.</summary> | ||||||
| </Docs> | ||||||
| </Member> | ||||||
| <Member MemberName="TerminalServerAware"> | ||||||
|
There was a problem hiding this comment. Do we have a description for TerminalServerAware? There was a problem hiding this comment. Not in the source comments: src/System.Reflection.Metadata/src/System/Reflection/PortableExecutable/PEFileFlags.cs#L113 This enum value was introduced in the very first commit of .NET Core: dotnet/corefx@f11305d So the API is as old as Framework. But judging by the value, and a quick search I did for these terms, this is my proposed description, @rpetrusha:
@GrabYourPitchforks @steveharter as the area owners, is this description good enough for you? There was a problem hiding this comment. Seems reasonable to me, but I am not an expert. |
||||||
|
|
@@ -298,7 +298,7 @@ | |||||
| </ReturnValue> | ||||||
| <MemberValue>4</MemberValue> | ||||||
| <Docs> | ||||||
| <summary>Reserved.</summary> | ||||||
| </Docs> | ||||||
| </Member> | ||||||
| <Member MemberName="ThreadTerm"> | ||||||
|
|
@@ -323,7 +323,7 @@ | |||||
| </ReturnValue> | ||||||
| <MemberValue>8</MemberValue> | ||||||
| <Docs> | ||||||
| <summary>Reserved.</summary> | ||||||
| </Docs> | ||||||
| </Member> | ||||||
| <Member MemberName="WdmDriver"> | ||||||
|
|
@@ -348,7 +348,7 @@ | |||||
| </ReturnValue> | ||||||
| <MemberValue>8192</MemberValue> | ||||||
| <Docs> | ||||||
| <summary>Driver uses WDM model.</summary> | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| </Docs> | ||||||
| </Member> | ||||||
| </Members> | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a type summary, something like "Describes the characteristics of a dynamic link library."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type summary sounds good to me, I will apply it.
@GrabYourPitchforks @steveharter as the area owners, do you agree with the type summary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, @tmat please take a look at this PR as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm