Automatically port Reflection.PortableExecutable.DebugDirectory* APIs #3196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
added
new-content
carlossanlop
requested review from
GrabYourPitchforks,
steveharter,
rpetrusha and
mairaw
|
closing and reopening for a clean build. |
rpetrusha
suggested changes
Sep 26, 2019
There was a problem hiding this comment.
I've directly edited all three files, @carlossanlop. Please review them. I also left two questions/comments.
| @@ -65,11 +65,14 @@ | |||
| <Parameter Name="portablePdbVersion" Type="System.UInt16" Index="2" FrameworkAlternate="netcore-1.1;netcore-2.0;netcore-2.1;netcore-2.2;netcore-3.0" /> | |||
| @@ -42,7 +42,16 @@ | |||
| </ReturnValue> | |||
There was a problem hiding this comment.
It would be good to add an enum type description.
|
@tmat your help would be hugely appreciated here as well. There are a few extra fields that need a summary (they were not documented in source). |
tmat
reviewed
Sep 27, 2019
| <remarks> | ||
| <format type="text/markdown"><
There was a problem hiding this comment.
Remarks [](start = 1, length = 9)
Empty remarks?
tmat
reviewed
Sep 27, 2019
| @@ -158,7 +191,7 @@ | |||
| </ReturnValue> | |||
| <MemberValue>0</MemberValue> | |||
| <Docs> | |||
| <summary>To be added.</summary> | |||
| <summary>An unknown value that is ignored by all tools.</summary> | |||
rpetrusha
approved these changes
Oct 11, 2019
rpetrusha
added
verify-build-before-merge
and removed
waiting-on-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.