Skip to content

Conversation

carlossanlop
Copy link
Contributor

No description provided.

@carlossanlop carlossanlop added new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews 🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases labels Sep 16, 2019
@carlossanlop carlossanlop added this to the September 2019 milestone Sep 16, 2019
@carlossanlop carlossanlop self-assigned this Sep 16, 2019
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made direct edits to the file once again, @carlossanlop. Please examine them and let me know if they're OK.

Copy link
Contributor

@sdmaclea sdmaclea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except as commented

<summary>To be added.</summary>
<value>To be added.</value>
<summary>Gets the number of relocation entries for the section.</summary>
<value>the number of relocation entries for the section. Its value is zero for PE images.</value>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<value>the number of relocation entries for the section. Its value is zero for PE images.</value>
<value>The number of relocation entries for the section. Its value is zero for PE images.</value>

@rpetrusha rpetrusha added verify-build-before-merge and removed waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews labels Oct 11, 2019
@rpetrusha rpetrusha merged commit e1ccc67 into dotnet:master Oct 11, 2019
@carlossanlop carlossanlop deleted the SectionHeader branch October 21, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases new-content Indicates PRs that contain new articles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants