Skip to content

Conversation

FarhadShariatzadeh
Copy link
Contributor

Adding a short summary for Array.Fill(T[], T) method

I just explained what this method does.

Co-Authored-By: MSDN.WhiteKnight <[email protected]>
@rpetrusha rpetrusha added this to the September 2019 milestone Sep 26, 2019
@rpetrusha rpetrusha added the ✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository label Sep 26, 2019
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @FarhadShariatzadeh, for contributing to the dotnet/dotnet-api-docs repo and documenting one of the overloads of Array.Fill. I've made some suggestions so that the overload would be fully documented. Would you also like to document the Fill<T>(T[], T) overload?

FarhadShariatzadeh and others added 2 commits September 26, 2019 16:15
Co-Authored-By: Ron Petrusha <[email protected]>
Co-Authored-By: Ron Petrusha <[email protected]>
@FarhadShariatzadeh
Copy link
Contributor Author

Thank you, @FarhadShariatzadeh, for contributing to the dotnet/dotnet-api-docs repo and documenting one of the overloads of Array.Fill. I've made some suggestions so that the overload would be fully documented. Would you also like to document the Fill(T[], T) overload?

My pleasure @rpetrusha. Thank you for reviewing my pull request. Yes, I like to document the Fill(T[], T) overload as well. I will send a new pull request for that soon.

Co-Authored-By: Ron Petrusha <[email protected]>
@FarhadShariatzadeh
Copy link
Contributor Author

Hello @rpetrusha, I was wondering if my pull request is ready to merge. Would you please let me know if I need to make any more changes? Thank you!

@rpetrusha
Copy link

Yes, this is ready to merge, @FarhadShariatzadeh. Sorry for the delay. I've resolved a merge conflict, so I'll merge as soon as the build completes successfully.

@FarhadShariatzadeh
Copy link
Contributor Author

Yes, this is ready to merge, @FarhadShariatzadeh. Sorry for the delay. I've resolved a merge conflict, so I'll merge as soon as the build completes successfully.

Awesome! no problem, Thank you very much!!

@rpetrusha rpetrusha merged commit d5baba0 into dotnet:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants