Skip to content

Conversation

carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented Sep 18, 2019

I corrected some whitespaces, not sure if they will get reverted by the compiler.

Area owners: @tannergooding@ViktorHofer

@carlossanlop carlossanlop added new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews 🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases labels Sep 18, 2019
@carlossanlop carlossanlop added this to the September 2019 milestone Sep 18, 2019
@carlossanlop carlossanlop self-assigned this Sep 18, 2019
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some suggestions for you to consider, @carlossanlop.

@BillWagner
Copy link
Member

@carlossanlop I applied Ron's suggestions, and I think everything is good. If you're happy with this now, I'll :shipit:

@carlossanlop
Copy link
Contributor Author

@BillWagner :shipit: 👍

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All feedback has been incorporated. This is ready to :shipit:

@BillWagner BillWagner merged commit e1aa98a into dotnet:master Oct 25, 2019
@carlossanlop carlossanlop deleted the Numerics_BigInteger branch November 6, 2019 18:51
@mairaw mairaw removed the waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews label Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases new-content Indicates PRs that contain new articles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants