Skip to content

updating Random.xml for Try .NET #3219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 11, 2020
Merged

updating Random.xml for Try .NET #3219

merged 10 commits into from
Jan 11, 2020

Conversation

WilliamAntonRohm
Copy link
Contributor

The 23 updated sample files are already merged in dotnet/samples#1522.

@mairaw
Copy link
Contributor

mairaw commented Sep 20, 2019

I stopped in the middle of my review last night 😄. I had some comments. I'll still post them as soon as I'm done.

@WilliamAntonRohm WilliamAntonRohm mentioned this pull request Sep 24, 2019
Merged
@mairaw mairaw added the vendor-project Indicates the issue/pr is related to a vendor project. label Oct 22, 2019
@mairaw mairaw added this to the October 2019 milestone Oct 23, 2019
@mairaw mairaw closed this Dec 6, 2019
@mairaw mairaw reopened this Dec 6, 2019
@mairaw
Copy link
Contributor

mairaw commented Dec 6, 2019

need a fresh build

mairaw
mairaw requested changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WilliamAntonRohm. Left you a few comments to be addressed before we can merge this.

@WilliamAntonRohm WilliamAntonRohm mentioned this pull request Dec 20, 2019
Merged
WilliamAntonRohm
WilliamAntonRohm commented Dec 27, 2019
View reviewed changes
Copy link
Contributor Author

@WilliamAntonRohm WilliamAntonRohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Not sure why GitHub started a review on my behalf.)

@WilliamAntonRohm
Copy link
Contributor Author

@mairaw -- Maira, please review these changes.

@mairaw mairaw modified the milestones: October 2019, January 2020 Jan 9, 2020
mairaw
mairaw approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will be ready to merge once the build finishes with the changes I just made.

mairaw
mairaw approved these changes Jan 11, 2020
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @WilliamAntonRohm!

@mairaw mairaw merged commit dbfdabc into dotnet:master Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw mairaw approved these changes

Assignees

@WilliamAntonRohm WilliamAntonRohm

Labels
vendor-project Indicates the issue/pr is related to a vendor project.
Projects
None yet
Milestone
January 2020
Development

Successfully merging this pull request may close these issues.
2 participants
@WilliamAntonRohm @mairaw