Skip to content

Migrate content from MSDN #3286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 4, 2019
Merged

Migrate content from MSDN #3286

merged 7 commits into from
Oct 4, 2019

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Oct 2, 2019

No description provided.

@mairaw mairaw added the migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN label Oct 2, 2019
@mairaw mairaw added this to the October 2019 milestone Oct 2, 2019
@mairaw mairaw self-assigned this Oct 2, 2019
rpetrusha
rpetrusha approved these changes Oct 3, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left two suggestions, @mairaw, since the description of the event arguments parameter doesn't appear in the build. You can merge when ready.

@mairaw
Copy link
Contributor Author

mairaw commented Oct 3, 2019

Thanks @rpetrusha. That was a copy and paste error. 😢

@mairaw mairaw merged commit 7e23b87 into master Oct 4, 2019
@mairaw mairaw deleted the mairaw-patch-1 branch October 4, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mairaw mairaw

Labels
migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN
Projects
None yet
Milestone
October 2019
Development

Successfully merging this pull request may close these issues.
2 participants
@mairaw @rpetrusha