Temporarily remove obsolete attribute #3320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpetrusha
approved these changes
Oct 10, 2019
There was a problem hiding this comment.
LGTM. But it might be best to also add a note box with something like the following:
The SmtpClient class is obsolete in Xamarin. However,
- It is included in the .NET Standard and therefore must part part of any .NET implementation.
- It is present and can be used in .NET Framework 4 through .NET Framework 4.8.
- It is usable in .NET Core, but its use is not recommended.
|
Good idea. |
|
Also I think we could add the text from https://github.com/dotnet/platform-compat/blob/master/docs/DE0005.md to here instead of linking to that, so it can get localized. Thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attribute causes too much customer confusion. I'll have to remember to add this back on every CI run.
Related to #2986
Internal review URL