Skip to content

Add remarks on disposable ctor parameter to System.Net.Http.StreamCon… #3357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2020
Merged

Add remarks on disposable ctor parameter to System.Net.Http.StreamCon… #3357

merged 3 commits into from
Aug 21, 2020

Conversation

JJS
Copy link
Contributor

@JJS JJS commented Oct 16, 2019

…tent (#3339)

Summary

Added remarks for the System.Net.Http.StreamContent constructors disposing the passed stream.

Fixes #3339

@JJS JJS requested a review from karelz as a code owner October 16, 2019 20:13
@dnfclas
Copy link

dnfclas commented Oct 16, 2019

CLA assistant check
All CLA requirements met.

@mairaw mairaw added this to the October 2019 milestone Oct 17, 2019
@Thraka Thraka added the ✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository label Oct 30, 2019
@BillWagner BillWagner modified the milestones: October 2019, March 2020 Mar 2, 2020
@BillWagner
Copy link
Member

ping @carlossanlop

@carlossanlop carlossanlop requested a review from a team March 2, 2020 19:59
@BillWagner BillWagner modified the milestones: March 2020, June 2020 Jun 1, 2020
@aik-jahoda
Copy link
Contributor

@aik-jahoda aik-jahoda self-requested a review July 9, 2020 12:58
@carlossanlop
Copy link
Contributor

@aik-jahoda It seems the build output was too old and got deleted. If you expand the "Show all checks" section, then click on "Details" in the OpenPublishing.Build row, the page is gone.

The build passed though, so the formatting was correct. And the xref links look correct to me too.

If you want to double check the output, we can run the build again. @dotnet/docs do you know how to re-run the build?

@gewarren
Copy link
Contributor

gewarren commented Jul 9, 2020

You just close/reopen the PR to trigger a new build. I'll do that now.

@gewarren gewarren closed this Jul 9, 2020
@gewarren gewarren reopened this Jul 9, 2020
Copy link
Contributor

@aik-jahoda aik-jahoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gewarren gewarren merged commit c6788aa into dotnet:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Net ✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add information about StreamContent disposing the content stream
10 participants