Guid.xml updates for Try .NET #3393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mairaw
added
the
vendor-project
mairaw
requested changes
Oct 23, 2019
There was a problem hiding this comment.
Thanks @WilliamAntonRohm. Left a couple of comments. Can you also make sure your other PRs don't have the same issue?
|
@mairaw -- Maira, this one is ready for your review. |
|
Need a new build |
mairaw
reviewed
Dec 6, 2019
Co-Authored-By: Maira Wenzel <[email protected]>
Co-Authored-By: Maira Wenzel <[email protected]>
Co-Authored-By: Maira Wenzel <[email protected]>
Co-Authored-By: Maira Wenzel <[email protected]>
Co-Authored-By: Maira Wenzel <[email protected]>
Co-Authored-By: Maira Wenzel <[email protected]>
|
@mairaw -- thank you for your detailed review. I believe this PR is good to go! |
mairaw
reviewed
Dec 20, 2019
|
@mairaw -- Maira, please review these changes if this build ever finishes :) |
mairaw
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
samples PR already merged -- dotnet/samples#1654