Skip to content

Fill in some missing docs for SqlClient #3417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2019

Conversation

roji
Copy link
Member

@roji roji commented Oct 26, 2019

@roji roji requested a review from stevestein as a code owner October 26, 2019 08:37
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I'll :shipit: now.

@BillWagner
Copy link
Member

closing & reopening to start a new build.

@BillWagner BillWagner closed this Oct 28, 2019
@BillWagner BillWagner reopened this Oct 28, 2019
@BillWagner
Copy link
Member

I can't spot what's causing the build error.

@mairaw Do you see it?

@mairaw
Copy link
Contributor

mairaw commented Oct 28, 2019

Made a change. Hopefully it’ll pass now.

@mairaw mairaw added this to the October 2019 milestone Oct 28, 2019
@mairaw mairaw closed this Oct 28, 2019
@mairaw mairaw reopened this Oct 28, 2019
@mairaw
Copy link
Contributor

mairaw commented Oct 28, 2019

Weird error in the build report. Trying again.

@mairaw mairaw merged commit a39d17c into dotnet:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants