Skip to content

Fill in some missing docs for SqlClient #3417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2019
Merged

Fill in some missing docs for SqlClient #3417

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d21b4e
Fill in some missing docs for SqlClient
roji Oct 26, 2019
f40fe4c
Fix build error
mairaw Oct 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions xml/System.Data.SqlClient/SqlDataReader.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,9 +246,17 @@
<Parameter Name="disposing" Type="System.Boolean" Index="0" FrameworkAlternate="netcore-2.0;netcore-2.1;netcore-2.2;netcore-3.0" />
</Parameters>
<Docs>
<param name="disposing">To be added.</param>
<summary>To be added.</summary>
<remarks>To be added.</remarks>
<param name="disposing">
<see langword="true" /> to release managed and unmanaged resources; <see langword="false" /> to release only unmanaged resources.</param>
<summary>Releases the managed resources used by the <see cref="T:System.Data.SqlClient.SqlDataReader" /> and optionally releases the unmanaged resources.</summary>
<remarks>
<format type="text/markdown"><![CDATA[

## Remarks
This method calls <xref:System.Data.SqlClient.SqlDataReader.Close%2A>.

]]></format>
</remarks>
</Docs>
</Member>
<Member MemberName="FieldCount">
Expand Down Expand Up @@ -656,8 +664,8 @@
</ReturnValue>
<Parameters />
<Docs>
<summary>To be added.</summary>
<returns>To be added.</returns>
<summary>Gets the column schema (<see cref="T:System.Data.Common.DbColumn" /> collection).</summary>
<returns>The column schema (<see cref="T:System.Data.Common.DbColumn" /> collection).</returns>
<remarks>To be added.</remarks>
</Docs>
</Member>
Expand Down