Skip to content

Document TryParse Span method overloads for System.B-G #3433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2019
Merged

Document TryParse Span method overloads for System.B-G #3433

merged 2 commits into from
Nov 7, 2019

Conversation

carlossanlop
Copy link
Contributor

Types: Boolean, Byte, DateTime, DateTimeoffset, Decimal, Double, Enum, Guid

@carlossanlop
Document TryParse Span methods overloads for Boolean, Byte, DateTime,…
42022c4 
… DateTimeoffset, Decimal, Double, Enum, Guid
@carlossanlop carlossanlop added new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews 🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases labels Nov 2, 2019
@carlossanlop carlossanlop added this to the November 2019 milestone Nov 2, 2019
@carlossanlop carlossanlop requested a review from mairaw November 2, 2019 02:31
@carlossanlop carlossanlop self-assigned this Nov 2, 2019
carlossanlop
carlossanlop commented Nov 2, 2019
View reviewed changes
carlossanlop
carlossanlop commented Nov 2, 2019
View reviewed changes
carlossanlop
carlossanlop commented Nov 2, 2019
View reviewed changes
carlossanlop
carlossanlop commented Nov 2, 2019
View reviewed changes
carlossanlop
carlossanlop commented Nov 2, 2019
View reviewed changes
carlossanlop
carlossanlop commented Nov 2, 2019
View reviewed changes
carlossanlop
carlossanlop commented Nov 2, 2019
View reviewed changes
carlossanlop
carlossanlop commented Nov 2, 2019
View reviewed changes
carlossanlop
carlossanlop commented Nov 2, 2019
View reviewed changes
carlossanlop
carlossanlop commented Nov 2, 2019
View reviewed changes
@carlossanlop carlossanlop changed the title Document TryParse Span methods overloads for System.B-G Document TryParse Span method overloads for System.B-G Nov 2, 2019
@carlossanlop carlossanlop requested a review from a team November 5, 2019 17:58
@carlossanlop
Copy link
Contributor Author

Thank you for the approval @Thraka. The build passed without any warnings. Would you mind merging it? Or as @BillWagner would say, should we :shipit: ?

@carlossanlop carlossanlop added verify-build-before-merge and removed waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews labels Nov 6, 2019
@gewarren
Copy link
Contributor

gewarren commented Nov 6, 2019

Thank you for the approval @Thraka. The build passed without any warnings. Would you mind merging it? Or as @BillWagner would say, should we :shipit: ?

Someone needs to make Bill a ship-it squirrel t-shirt.

@carlossanlop
Copy link
Contributor Author

Someone needs to make Bill a ship-it squirrel t-shirt.

Or his GitHub picture 😄

@Thraka Thraka merged commit 62aa16c into dotnet:master Nov 7, 2019
@carlossanlop carlossanlop deleted the TryParse_Span_B-G branch November 7, 2019 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw Awaiting requested review from mairaw

1 more reviewer

@Thraka Thraka Thraka approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@carlossanlop carlossanlop

Labels
🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases new-content Indicates PRs that contain new articles
Projects
None yet
Milestone
November 2019
Development

Successfully merging this pull request may close these issues.
3 participants
@carlossanlop @gewarren @Thraka