Skip to content

Document TryParseExact Span method overloads in System date and time types #3435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 6, 2019
Merged

Document TryParseExact Span method overloads in System date and time types #3435

merged 4 commits into from
Nov 6, 2019

Conversation

carlossanlop
Copy link
Contributor

Types: DateTime, DateTimeOffset and TimeSpan.

@carlossanlop carlossanlop added new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews 🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases labels Nov 2, 2019
@carlossanlop carlossanlop added this to the November 2019 milestone Nov 2, 2019
@carlossanlop carlossanlop self-assigned this Nov 2, 2019
carlossanlop
carlossanlop commented Nov 2, 2019
View reviewed changes
carlossanlop
carlossanlop commented Nov 2, 2019
View reviewed changes
carlossanlop
carlossanlop commented Nov 2, 2019
View reviewed changes
carlossanlop
carlossanlop commented Nov 2, 2019
View reviewed changes
@carlossanlop carlossanlop requested a review from a team November 5, 2019 17:58
BillWagner
BillWagner approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These also LGTM @carlossanlop

I'll :shipit: now.

@BillWagner BillWagner merged commit 517c34c into dotnet:master Nov 6, 2019
@carlossanlop carlossanlop deleted the TryParseExact_Span branch November 6, 2019 18:20
@mairaw mairaw removed the waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews label Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees

@carlossanlop carlossanlop

Labels
area-System.DateTime 🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases new-content Indicates PRs that contain new articles
Projects
None yet
Milestone
November 2019
Development

Successfully merging this pull request may close these issues.
4 participants
@carlossanlop @BillWagner @jeffhandley @mairaw