Skip to content

Try .NET -- String.xml -- re-adding interactivity to sample refs #3458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

WilliamAntonRohm
Copy link
Contributor

@WilliamAntonRohm WilliamAntonRohm commented Nov 8, 2019

(this PR has been superseded by the currently mergeable #3773)

Updated this minute's version of String.xml to include all interactive samples

Waiting on this build to double-check placement of interactive Notes

@mairaw mairaw added the vendor-project Indicates the issue/pr is related to a vendor project. label Nov 11, 2019
@mairaw
Copy link
Contributor

mairaw commented Nov 13, 2019

Replaces #2971 correct?

@WilliamAntonRohm
Copy link
Contributor Author

Yes -- this one (3458) is the "real" String.xml PR

@mairaw mairaw self-requested a review November 22, 2019 09:33
@mairaw mairaw added this to the November 2019 milestone Nov 22, 2019
@mairaw mairaw closed this Dec 20, 2019
@mairaw mairaw reopened this Dec 20, 2019
@mairaw
Copy link
Contributor

mairaw commented Dec 20, 2019

Need a fresh build

@WilliamAntonRohm
Copy link
Contributor Author

@mairaw -- Maira, please review these changes.

@mairaw
Copy link
Contributor

mairaw commented Jan 11, 2020

@WilliamAntonRohm can you resolve the conflicts here and also remove any references to the include notes? Thanks.

@WilliamAntonRohm
Copy link
Contributor Author

@mairaw -- Maira, I've re-added just the -interactive samples into a new replacement PR #3773 which is currently mergeable.

@mairaw mairaw closed this Jan 17, 2020
@mairaw mairaw removed this from the November 2019 milestone Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vendor-project Indicates the issue/pr is related to a vendor project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants