Skip to content

Add missing property descriptions for System.Type #3481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 5, 2019
Merged

Add missing property descriptions for System.Type #3481

merged 3 commits into from
Dec 5, 2019

Conversation

MSDN-WhiteKnight
Copy link
Contributor

Summary

Add missing property descriptions for System.Type

@mairaw
Copy link
Contributor

mairaw commented Nov 20, 2019

Thanks @MSDN-WhiteKnight. @carlossanlop do you know who owns this?

mairaw
mairaw reviewed Nov 20, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments...

@MSDN-WhiteKnight
Copy link
Contributor Author

I can't apply suggestions via GitHub web interface (it errors with cryptic message like "diff already changed", probably related to large size of Type.xml), so i applied them manually.

@carlossanlop
Copy link
Contributor

A week ago I merged this PR which added some missing documentation in Type.xml APIs.

@MSDN-WhiteKnight can you please rebase your branch to master to ensure your change is not modifying APIs that had already been documented?

@carlossanlop
Copy link
Contributor

Oh and also:

I can't apply suggestions via GitHub web interface (it errors with cryptic message like "diff already changed", probably related to large size of Type.xml), so i applied them manually.

Yes, your hypothesis was correct, and manually applying suggestions was the correct thing to do. Type.xml is one of the few files in this repo that can't be modified directly in GitHub because they are too large. Other files with this problem as String.xml and Convert.xml.

@MSDN-WhiteKnight
Copy link
Contributor Author

Rebased branch against the latest master and cleaned up commit history. Everything should be up to date now.

@carlossanlop carlossanlop added 🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases new-content Indicates PRs that contain new articles labels Dec 5, 2019
@carlossanlop carlossanlop added this to the December 2019 milestone Dec 5, 2019
carlossanlop
carlossanlop approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change, @MSDN-WhiteKnight . I'll merge it.

@carlossanlop carlossanlop merged commit 6d40805 into dotnet:master Dec 5, 2019
@MSDN-WhiteKnight MSDN-WhiteKnight deleted the type-updates branch December 9, 2019 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw mairaw left review comments

+1 more reviewer

@carlossanlop carlossanlop carlossanlop approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@MSDN-WhiteKnight MSDN-WhiteKnight

Labels
🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases new-content Indicates PRs that contain new articles
Projects
None yet
Milestone
December 2019
Development

Successfully merging this pull request may close these issues.
3 participants
@MSDN-WhiteKnight @mairaw @carlossanlop