Skip to content

Document System.IO.Directory #3504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 23, 2019
Merged

Document System.IO.Directory #3504

merged 3 commits into from
Nov 23, 2019

Conversation

carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented Nov 15, 2019 •
edited
Loading

No description provided.

@carlossanlop carlossanlop added new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews 🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases labels Nov 15, 2019
@carlossanlop carlossanlop added this to the November 2019 milestone Nov 15, 2019
@carlossanlop carlossanlop self-assigned this Nov 15, 2019
mairaw
mairaw reviewed Nov 15, 2019
View reviewed changes
@mairaw mairaw self-requested a review November 21, 2019 01:51
@carlossanlop
Copy link
Contributor Author

@mairaw would you mind taking another look?

mairaw
mairaw approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some comments for you to consider but they are all optional and could potentially be addressed at a later time.

carlossanlop
carlossanlop commented Nov 22, 2019
View reviewed changes
carlossanlop
carlossanlop commented Nov 22, 2019
View reviewed changes
carlossanlop
carlossanlop commented Nov 22, 2019
View reviewed changes
carlossanlop
carlossanlop commented Nov 22, 2019
View reviewed changes
carlossanlop
carlossanlop commented Nov 22, 2019
View reviewed changes
@carlossanlop carlossanlop merged commit e3d2921 into dotnet:master Nov 23, 2019
@carlossanlop carlossanlop deleted the Directory branch November 23, 2019 00:53
@mairaw mairaw removed the waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews label Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw mairaw approved these changes

@JeremyKuhne JeremyKuhne Awaiting requested review from JeremyKuhne

Assignees

@carlossanlop carlossanlop

Labels
🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases new-content Indicates PRs that contain new articles
Projects
None yet
Milestone
November 2019
Development

Successfully merging this pull request may close these issues.
2 participants
@carlossanlop @mairaw