Skip to content

Document System.IO.DirectoryInfo #3505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 19, 2019
Merged

Document System.IO.DirectoryInfo #3505

merged 2 commits into from
Nov 19, 2019

Conversation

carlossanlop
Copy link
Contributor

No description provided.

@carlossanlop carlossanlop added new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews 🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases labels Nov 15, 2019
@carlossanlop carlossanlop added this to the November 2019 milestone Nov 15, 2019
@carlossanlop carlossanlop self-assigned this Nov 15, 2019
@carlossanlop carlossanlop requested a review from a team November 19, 2019 17:35
@Thraka Thraka requested review from Thraka and removed request for a team November 19, 2019 18:40
Thraka
Thraka approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@Thraka Thraka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I noticed two unescaped * characters and a double space. I fixed those with find/replace, about 16 matches each.

@carlossanlop
Copy link
Contributor Author

LGTM. I noticed two unescaped * characters and a double space. I fixed those with find/replace, about 16 matches each.

Thanks. I double checked the preview page and they look good:
https://review.docs.microsoft.com/en-us/dotnet/api/system.io.directoryinfo.enumeratedirectories?view=netcore-3.0&branch=pr-en-us-3505

I wasn't aware that asterisks had to be escaped in markdown (for example, this is unescaped: *).

@carlossanlop carlossanlop merged commit a519fb3 into dotnet:master Nov 19, 2019
@carlossanlop carlossanlop deleted the DirectoryInfo branch November 19, 2019 21:10
@mairaw mairaw removed the waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews label Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeremyKuhne JeremyKuhne Awaiting requested review from JeremyKuhne

1 more reviewer

@Thraka Thraka Thraka approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@carlossanlop carlossanlop

Labels
🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases new-content Indicates PRs that contain new articles
Projects
None yet
Milestone
November 2019
Development

Successfully merging this pull request may close these issues.
3 participants
@carlossanlop @Thraka @mairaw