Add missing, and update existing, ECDH API documentation. #3542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
added
🏁 Release: .NET Core 2.x
|
I read through everything, and what's here looks good, once you resolve Carlos' comments. @mairaw Some of the remarks sections contain "To be added". Is that OK, or is that section mandatory? (The wiki didn't make that clear). |
carlossanlop
approved these changes
Nov 21, 2019
carlossanlop
suggested changes
Nov 21, 2019
There was a problem hiding this comment.
There were some build warnings. I'll point them out in the code. Can you please take a look, @bartonjs?
carlossanlop
approved these changes
Nov 22, 2019
mairaw
approved these changes
Nov 22, 2019
mairaw
removed
the
waiting-on-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @carlossanlop