Skip to content

Improve System.GC documentation #3559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Improve System.GC documentation #3559

merged 1 commit into from
Nov 25, 2019

Conversation

MSDN-WhiteKnight
Copy link
Contributor

Summary

  • Format identifiers as xrefs to avoid localizing them
  • Remove "Notes for inheritors" block (it makes no sence for GC which is static class you can't inherit from), and move its contents to remarks
  • Replace MSDN links to MS Docs

- Format identifiers as xrefs to avoid localizing them
- Remove "Notes for inheritors" block (it makes no sence for GC which is static class you can't inherit from), and move its contents to remarks
- Replace MSDN links to MS Docs
@dotnet-bot dotnet-bot added this to the November 2019 milestone Nov 24, 2019
@BillWagner BillWagner requested a review from gewarren November 25, 2019 16:43
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a suggestion unrelated to your changes if you wish to incorporate it. Thanks for submitting this PR.

@@ -218,7 +218,7 @@
<exception cref="T:System.InvalidOperationException">This member is not available when concurrent garbage collection is enabled. See the [&lt;gcConcurrent&gt;](~/docs/framework/configure-apps/file-schema/runtime/gcconcurrent-element.md) runtime setting for information about how to disable concurrent garbage collection.</exception>
<permission cref="F:System.Security.Permissions.SecurityAction.LinkDemand">for full trust for the immediate caller. This member cannot be used by partially trusted code.</permission>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<permission cref="F:System.Security.Permissions.SecurityAction.LinkDemand">for full trust for the immediate caller. This member cannot be used by partially trusted code.</permission>
<permission cref="F:System.Security.Permissions.SecurityAction.LinkDemand">requires full trust for the immediate caller. This member cannot be used by partially trusted code.</permission>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and merge as-is.

@gewarren gewarren merged commit 85bce73 into dotnet:master Nov 25, 2019
@MSDN-WhiteKnight MSDN-WhiteKnight deleted the patch-1 branch November 27, 2019 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants