Skip to content

Add missing, and update existing, ECDsa API documentation #3564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 26, 2019
Merged

Add missing, and update existing, ECDsa API documentation #3564

merged 3 commits into from
Nov 26, 2019

Conversation

bartonjs
Copy link
Member

@carlossanlop carlossanlop requested review from jozkee, a team and carlossanlop November 25, 2019 22:22
@carlossanlop carlossanlop added 🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews labels Nov 25, 2019
@carlossanlop carlossanlop added this to the November 2019 milestone Nov 25, 2019
carlossanlop
carlossanlop reviewed Nov 25, 2019
View reviewed changes
carlossanlop
carlossanlop reviewed Nov 25, 2019
View reviewed changes
carlossanlop
carlossanlop reviewed Nov 25, 2019
View reviewed changes
carlossanlop
carlossanlop reviewed Nov 25, 2019
View reviewed changes
carlossanlop
carlossanlop suggested changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this change, @bartonjs. I left some suggestions to fix build warnings. Can you please take a look?

@BillWagner BillWagner requested review from BillWagner and removed request for a team November 26, 2019 14:16
@BillWagner BillWagner self-assigned this Nov 26, 2019
@BillWagner
Copy link
Member

@bartonjs I reviewed everything in this PR, and once the build warnings are addressed, thisis ready to :shipit:

I'll give it a final look once that's done. Just @ - mention me when it's ready.

@bartonjs
Copy link
Member Author

Okay @carlossanlop and @BillWagner, I think everything looks right now.

@carlossanlop
Copy link
Contributor

Thanks for fixing the warnings.
I learned two new things from this: apparently spaces are not allowed between parameters inside xrefs, and the word overload can be used instead of the %2A suffix.

@carlossanlop carlossanlop merged commit a70f832 into dotnet:master Nov 26, 2019
@bartonjs
Copy link
Member Author

and the word overload can be used instead of the %2A suffix.

The suffix is for xrefs, Overload is for altmember. 😄

@bartonjs bartonjs deleted the ecdsa branch November 26, 2019 18:23
@carlossanlop
Copy link
Contributor

I'm learning too many things today.

@mairaw mairaw removed the waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews label Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jozkee jozkee Awaiting requested review from jozkee

@BillWagner BillWagner Awaiting requested review from BillWagner

1 more reviewer

@carlossanlop carlossanlop carlossanlop approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@BillWagner BillWagner

@bartonjs bartonjs

Labels
🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases new-content Indicates PRs that contain new articles
Projects
None yet
Milestone
November 2019
Development

Successfully merging this pull request may close these issues.
4 participants
@bartonjs @BillWagner @carlossanlop @mairaw