Skip to content

Missing API docs part 2 - SA #3567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 10, 2019
Merged

Missing API docs part 2 - SA #3567

merged 5 commits into from
Dec 10, 2019

Conversation

steveada
Copy link
Contributor

@mairaw 42 changes in 9 files

@steveada
Copy link
Contributor Author

@KathleenDollard FYI that @mairaw will be assigning herself as reviewer

@mairaw mairaw added the vendor-project Indicates the issue/pr is related to a vendor project. label Dec 3, 2019
@mairaw mairaw added this to the December 2019 milestone Dec 4, 2019
@mairaw mairaw requested review from mairaw and removed request for KathleenDollard December 4, 2019 00:54
mairaw
mairaw requested changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @steveada. Left you some comments for you to consider before we merge this.

@mairaw
Copy link
Contributor

mairaw commented Dec 5, 2019

You can batch all my suggestions into a single commit using https://github.com/dotnet/dotnet-api-docs/pull/3567/files

steveada and others added 2 commits December 5, 2019 10:41
@steveada steveada closed this Dec 6, 2019
@steveada steveada reopened this Dec 6, 2019
mairaw
mairaw reviewed Dec 10, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found two missing property values...

@steveada
Copy link
Contributor Author

@mairaw Ready to go?

mairaw
mairaw approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready @steveada. Thanks!

@mairaw mairaw merged commit 18a8f93 into dotnet:master Dec 10, 2019
@steveada steveada deleted the missing_api_docs_2 branch December 10, 2019 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw mairaw approved these changes

Assignees

@steveada steveada

Labels
vendor-project Indicates the issue/pr is related to a vendor project.
Projects
None yet
Milestone
December 2019
Development

Successfully merging this pull request may close these issues.
2 participants
@steveada @mairaw