Skip to content

Conversation

bartonjs
Copy link
Member

@bartonjs bartonjs commented Dec 3, 2019

@carlossanlop carlossanlop requested review from jozkee, carlossanlop and a team December 3, 2019 18:50
@carlossanlop carlossanlop added 🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews labels Dec 3, 2019
@carlossanlop carlossanlop added this to the December 2019 milestone Dec 3, 2019
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change, @bartonjs. I left a few suggestions for you to consider.

Co-Authored-By: Carlos Sanchez Lopez <[email protected]>
@mairaw mairaw requested a review from carlossanlop December 4, 2019 00:24
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some comments for you to consider.

@carlossanlop carlossanlop merged commit 0e63d12 into dotnet:master Dec 5, 2019
@mairaw mairaw removed the waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews label Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases new-content Indicates PRs that contain new articles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants