Skip to content

Document System.Buffers.ReadOnlySequence #3620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 4, 2019
Merged

Document System.Buffers.ReadOnlySequence #3620

merged 5 commits into from
Dec 4, 2019

Conversation

carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop added new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews 🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases labels Dec 3, 2019
@carlossanlop carlossanlop added this to the December 2019 milestone Dec 3, 2019
@carlossanlop carlossanlop requested review from JeremyKuhne, layomia, jozkee and a team December 3, 2019 22:34
@carlossanlop carlossanlop self-assigned this Dec 3, 2019
@Thraka Thraka requested review from Thraka and removed request for a team December 3, 2019 22:42
mairaw
mairaw approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a few comments for you to consider.

@carlossanlop @mairaw
suggestions by mairaw
7e54520 
Co-Authored-By: Maira Wenzel <[email protected]>
@Thraka Thraka removed their request for review December 4, 2019 00:00
jozkee
jozkee approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@jozkee jozkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise; looks good.

@carlossanlop carlossanlop merged commit 00eeea0 into dotnet:master Dec 4, 2019
@carlossanlop carlossanlop deleted the ReadOnlySequence branch December 4, 2019 17:15
@mairaw mairaw removed the waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews label Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw mairaw approved these changes

@jozkee jozkee jozkee approved these changes

@JeremyKuhne JeremyKuhne Awaiting requested review from JeremyKuhne

@layomia layomia Awaiting requested review from layomia

Assignees

@carlossanlop carlossanlop

Labels
🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases new-content Indicates PRs that contain new articles
Projects
None yet
Milestone
December 2019
Development

Successfully merging this pull request may close these issues.
3 participants
@carlossanlop @mairaw @jozkee