Skip to content

Document when MemoryStream.TryGetBuffer returns false #3634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 6, 2019
Merged

Document when MemoryStream.TryGetBuffer returns false #3634

merged 2 commits into from
Dec 6, 2019

Conversation

carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop added the doc-enhancement Improve the current content label Dec 5, 2019
@carlossanlop carlossanlop requested review from JeremyKuhne, jozkee and a team December 5, 2019 23:07
@carlossanlop carlossanlop self-assigned this Dec 5, 2019
@dotnet-bot dotnet-bot added this to the December 2019 milestone Dec 5, 2019
@carlossanlop
Copy link
Contributor Author

Thanks for the approval, @Thraka .
There were warnings in the xrefs. I'm investigating how to indicate constructor DocIDs, because the # does not seem to be right.

mairaw
mairaw reviewed Dec 6, 2019
View reviewed changes
mairaw
mairaw reviewed Dec 6, 2019
View reviewed changes
mairaw
mairaw reviewed Dec 6, 2019
View reviewed changes
mairaw
mairaw reviewed Dec 6, 2019
View reviewed changes
mairaw
mairaw reviewed Dec 6, 2019
View reviewed changes
@carlossanlop carlossanlop merged commit b98e9fc into dotnet:master Dec 6, 2019
@carlossanlop carlossanlop deleted the MemoryStream_TryGetBuffer branch December 6, 2019 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw mairaw left review comments

@JeremyKuhne JeremyKuhne Awaiting requested review from JeremyKuhne

@jozkee jozkee Awaiting requested review from jozkee

+1 more reviewer

@Thraka Thraka Thraka approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@carlossanlop carlossanlop

Labels
doc-enhancement Improve the current content
Projects
None yet
Milestone
December 2019
Development

Successfully merging this pull request may close these issues.

Document when MemoryStream.TryGetBuffer returns false
4 participants
@carlossanlop @Thraka @mairaw @dotnet-bot