Skip to content

Document System.TimeSpan #3637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 7, 2019
Merged

Document System.TimeSpan #3637

merged 3 commits into from
Dec 7, 2019

Conversation

carlossanlop
Copy link
Contributor

There were 3 APIs left to document in this type:

  • CompareTo EII
  • TryParseExact
  • op_Multiply

@carlossanlop carlossanlop added new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews 🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases labels Dec 6, 2019
@carlossanlop carlossanlop added this to the December 2019 milestone Dec 6, 2019
@carlossanlop carlossanlop requested review from krwq, tarekgh, jozkee and a team December 6, 2019 00:57
@carlossanlop carlossanlop self-assigned this Dec 6, 2019
Thraka
Thraka approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@Thraka Thraka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change to address.

@carlossanlop carlossanlop added verify-build-before-merge and removed waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews labels Dec 7, 2019
@carlossanlop carlossanlop merged commit c9a87d4 into dotnet:master Dec 7, 2019
@carlossanlop carlossanlop deleted the TimeSpanMultiply branch December 7, 2019 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krwq krwq Awaiting requested review from krwq

@tarekgh tarekgh Awaiting requested review from tarekgh

@jozkee jozkee Awaiting requested review from jozkee

1 more reviewer

@Thraka Thraka Thraka approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@carlossanlop carlossanlop

Labels
🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases new-content Indicates PRs that contain new articles
Projects
None yet
Milestone
December 2019
Development

Successfully merging this pull request may close these issues.
3 participants
@carlossanlop @Thraka @mairaw