CI Update - remove shims from .NET Core #3661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mairaw
requested review from
KathleenDollard,
scottaddie and
stevestein
as code owners
mairaw
commented
Dec 11, 2019
| </ReturnValue> | ||
| <Parameters> | ||
| <Parameter Name="configurationBuilder" Type="Microsoft.Extensions.Configuration.IConfigurationBuilder" Index="0" FrameworkAlternate="dotnet-plat-ext-3.0" RefType="this" /> | ||
| <Parameter Name="configurationBuilder" Type="Microsoft.Extensions.Configuration.IConfigurationBuilder" RefType="this" Index="0" FrameworkAlternate="dotnet-plat-ext-3.0" /> |
There was a problem hiding this comment.
@joelmartinez can we make sure this doesn't change position from one version to the next?
There was a problem hiding this comment.
@mairaw we'll probably need to do some parameter sorting to make sure ... @mimisasouvanh, can you open a devops item on this? the functionality wouldn't be changing, just doing some sorting to maintain a consistent order
There was a problem hiding this comment.
I can file one. Just point me to the right DevOps instance. I never know. That's why filing in the repo was easier 😉
There was a problem hiding this comment.
lol ... ok ... here :) https://ceapex.visualstudio.com/Engineering/
carlossanlop
approved these changes
Dec 11, 2019
|
I don't think this PR introduced these. I'll have to look at those later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@roji @carlossanlop @safern
This will remove OdbcParameter.Offset among others that were incorrectly identified as .NET Core:
https://review.docs.microsoft.com/en-us/dotnet/api/system.data.odbc.odbcparameter.offset?view=xamarinmac-3.0&branch=remove-shims