Skip to content

Add new F# Console snippet references #3664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2019
Merged

Conversation

jpierson
Copy link
Contributor

@jpierson jpierson commented Dec 12, 2019

Summary

Adds references to some of the newly added snippets for the System.Console class which are written in F#.

Partially addresses dotnet/docs/issues/16105

[Edited by gewarren to add preview link]
https://review.docs.microsoft.com/en-us/dotnet/api/system.console?view=netframework-4.8&branch=pr-en-us-3664#remarks

@dotnet-bot dotnet-bot added this to the December 2019 milestone Dec 12, 2019
@jpierson
Copy link
Contributor Author

@tannergooding, @gewarren, could one of you please review these changes if you have the chance?

@gewarren
Copy link
Contributor

@cartermp Are you the right person to review this?

@mairaw
Copy link
Contributor

mairaw commented Dec 17, 2019

@cartermp already approved the samples, so we can also review this.

@jpierson
Copy link
Contributor Author

Yes, I noticed that you two have worked on other F# related API doc changes that's why I singled out both of you. Sorry if that was not the protocol and thanks!

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @jpierson! Thanks for doing this.

@mairaw mairaw merged commit a2a60d5 into dotnet:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants