Update live with current master #3665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Document System.*IntPtr.Equals (EII) * suggestions by maiaraw Co-Authored-By: Maira Wenzel <[email protected]> * IEquatable build warning
* Remove reference to nonexistent method in C# API The mentioned method overload of File.Move() doesn't actually exist in the C# version of this API. I have removed the reference to it and briefly described an alternative option. * Explain difference in .NET Core 3 and .NET Framework Co-Authored-By: Carlos Sanchez Lopez <[email protected]>
mairaw
requested review from
KathleenDollard,
scottaddie and
stevestein
as code owners
* Document caution regarding AdvanceTo's side effect After calling `PipeReader.AdvanceTo`, the `ReadResult.Buffer` property's backing data is recycled, leading to indeterministic changes to not only the content but its `Length` property. This isn't particular predictable as a consumer and the docs didn't make it clear either. * Use xref's Co-Authored-By: Bill Wagner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.