Skip to content

Fix remarks for JsonElement TryGetDouble and TryGetSingle #3719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 31, 2019
Merged

Fix remarks for JsonElement TryGetDouble and TryGetSingle #3719

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
10f14ed
Fix remarks for JsonElement TryGetDouble and TryGetSingle
ahsonkhan Dec 28, 2019
fd789ca
Update xml/System.Text.Json/JsonElement.xml
ahsonkhan Dec 31, 2019
ce6213b
Update xml/System.Text.Json/JsonElement.xml
ahsonkhan Dec 31, 2019
6bc6320
Apply suggestions from code review
ahsonkhan Dec 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions xml/System.Text.Json/JsonElement.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1159,7 +1159,7 @@ This method does not parse the contents of a JSON string value.

This method does not parse the contents of a JSON string value.

On .NET Core, this method does not return `false` for values larger than <xref:System.Double.MaxValue?displayProperty=nameWithType> or smaller than <xref:System.Double.MinValue?displayProperty=nameWithType>. Instead, it returns <see langword="true> and assigns <xref:System.Double.PositiveInfinity?displayProperty=nameWithType> or <xref:System.Double.NegativeInfinity?displayProperty=nameWithType> to `value`.
On .NET Core, this method does not return `false` for values larger than <xref:System.Double.MaxValue?displayProperty=nameWithType> or smaller than <xref:System.Double.MinValue?displayProperty=nameWithType>. Instead, it returns <see langword="true"> and assigns <xref:System.Double.PositiveInfinity?displayProperty=nameWithType> or <xref:System.Double.NegativeInfinity?displayProperty=nameWithType> to `value`.

]]></format>
</remarks>
Expand Down Expand Up @@ -1515,7 +1515,7 @@ This method does not parse the contents of a JSON string value.

This method does not parse the contents of a JSON string value.

On .NET Core, this method does not return `false` for values larger than <xref:System.Single.MaxValue?displayProperty=nameWithType> or smaller than <xref:System.Single.MinValue?displayProperty=nameWithType>). Instead, it returns `false` and assigns <xref:System.Single.PositiveInfinity?displayProperty=nameWithType> or <xref:System.Single.NegativeInfinity?displayProperty=nameWithType> to the `value` argument.
On .NET Core, this method does not return `false` for values larger than <xref:System.Single.MaxValue?displayProperty=nameWithType> or smaller than <xref:System.Single.MinValue?displayProperty=nameWithType>). Instead, it returns <see langword="true"> and assigns <xref:System.Single.PositiveInfinity?displayProperty=nameWithType> or <xref:System.Single.NegativeInfinity?displayProperty=nameWithType> to the `value` argument.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlossanlop - any ideas what caused the typo? Was these hand-written or does it point to a potential porting tool bug?

These were added in #2471.


]]></format>
</remarks>
Expand Down