Skip to content

Note performance counter permission distinction for interactive logons #3744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 22, 2020

Conversation

mriehm
Copy link
Contributor

@mriehm mriehm commented Jan 8, 2020

Summary

I noticed that users in interactive sessions can always view counter data, and only non-interactive logon sessions need to be in the Performance Monitoring Users group in order to view counter data, but the documentation here made no mention of the interactive vs non-interactive distinction, so I have added that information.

I noticed that this exception for interactive sessions was introduced in Vista SP1. In Vista RTM, users in interactive sessions had to be in the Performance Monitoring Users group in order to view counter data. I believe that is why this documentation does not mention the interactive session exception, because this documentation was probably written when Vista RTM was released and not updated since.

mriehm added 3 commits January 8, 2020 02:33
I noticed that users in interactive sessions can always view counter data, and only non-interactive logon sessions need to be in the Performance Monitoring Users group in order to view counter data, but the documentation here made no mention of the interactive vs non-interactive distinction, so I have added that information.

I noticed that this exception for interactive sessions was introduced in Vista SP1. In Vista RTM, users in interactive sessions had to be in the Performance Monitoring Users group in order to view counter data. I believe that is why this documentation does not mention the interactive session exception, because this documentation was probably written when Vista RTM was released and not updated since.
I noticed that users in interactive sessions can always view counter data, and only non-interactive logon sessions need to be in the Performance Monitoring Users group in order to view counter data, but the documentation here made no mention of the interactive vs non-interactive distinction, so I have added that information.

I noticed that this exception for interactive sessions was introduced in Vista SP1. In Vista RTM, users in interactive sessions had to be in the Performance Monitoring Users group in order to view counter data. I believe that is why this documentation does not mention the interactive session exception, because this documentation was probably written when Vista RTM was released and not updated since.
@dotnet-bot dotnet-bot added this to the December 2019 milestone Jan 8, 2020
@dnfclas
Copy link

dnfclas commented Jan 8, 2020

CLA assistant check
All CLA requirements met.

@mriehm
Copy link
Contributor Author

mriehm commented Jan 14, 2020

I just want to note that I submitted a similar pull request for the Win32 documentation, which was recently merged into master and is live: MicrosoftDocs/win32#174

https://docs.microsoft.com/en-us/windows/win32/perfctrs/limited-user-access-support

@mairaw mairaw added the ✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository label Jan 28, 2020
@mairaw
Copy link
Contributor

mairaw commented Jan 28, 2020

Thank you for your contribution @mriehm. @tommcdon @wtgodbe @krwq can you please review this change?

@mairaw mairaw requested review from tommcdon, wtgodbe and krwq January 28, 2020 08:26
@BillWagner BillWagner modified the milestones: December 2019, March 2020 Mar 2, 2020
@BillWagner
Copy link
Member

ping @carlossanlop Can you help get this reviewed?

@carlossanlop carlossanlop requested review from tarekgh, Anipik and noahfalk and removed request for krwq and wtgodbe March 2, 2020 20:04
@carlossanlop
Copy link
Contributor

Adding the new area owners of PerformanceCounter: @tarekgh @Anipik @tommcdon @noahfalk . Can you please help review this change?

@carlossanlop
Copy link
Contributor

@Anipik can you please review?

@BillWagner BillWagner modified the milestones: March 2020, June 2020 Jun 1, 2020
@gewarren gewarren merged commit 12539c6 into dotnet:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants