Update documentation for SerializationSurrogateProvider property #3748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
added
🏁 Release: .NET Core 2.x
carlossanlop
reviewed
Jan 8, 2020
xml/System.ServiceModel.Description/DataContractSerializerOperationBehavior.xml
Outdated
Show resolved
Hide resolved
carlossanlop
suggested changes
Jan 8, 2020
…ationBehavior.xml Co-Authored-By: Carlos Sanchez Lopez <[email protected]>
mairaw
approved these changes
Jan 8, 2020
| <summary>To be added.</summary> | ||
| <value>To be added.</value> | ||
| <summary>Gets or sets a surrogate provider to be used during the serialization and deserialization processes.</summary> | ||
| <value>An <see cref="T:System.Runtime.Serialization.ISerializationSurrogateProvider" /> that is used to provide a serialization surrogate used during serialization and deserialization.</value> |
There was a problem hiding this comment.
Given that the type is automatically shown (https://review.docs.microsoft.com/en-us/dotnet/api/System.ServiceModel.Description.DataContractSerializerOperationBehavior.SerializationSurrogateProvider?branch=pr-en-us-3748&view=dotnet-plat-ext-3.1#property-value), I think you can have the plain text here too
Suggested change
| <value>An <see cref="T:System.Runtime.Serialization.ISerializationSurrogateProvider" /> that is used to provide a serialization surrogate used during serialization and deserialization.</value> | |
| <value>A surrogate provider that is used to provide a serialization surrogate to be used during serialization and deserialization.</value> |
StephenMolloy
approved these changes
Jan 8, 2020
carlossanlop
approved these changes
Jan 8, 2020
|
I've applied the suggestion so we can merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added documentation for DataContractSerializerOperationBehavior.SerializationSurrogateProvider