Skip to content

Fixed incorrect data type parameter info #3749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2020

Conversation

balfourcraig
Copy link
Contributor

Math.ScaleB takes a double and an int, but the docs say it takes two floats. Docs changed to reflect method signature

Summary

Just a little docs update to reflect the method signature.

Math.ScaleB takes a double and an int, but the docs say it takes two floats. Docs changed to reflect method signature
@dotnet-bot dotnet-bot added this to the December 2019 milestone Jan 8, 2020
mairaw
mairaw previously requested changes Jan 9, 2020
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @balfourcraig for noticing and addressing the issue. Left just a small comment to be addressed before we can merge this.

@mairaw mairaw modified the milestones: December 2019, January 2020 Jan 9, 2020
@mairaw mairaw added the ✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository label Jan 9, 2020
@balfourcraig
Copy link
Contributor Author

Hi @mairaw ,
I'm sorry to ask, but what do I need to do now? I accepted the changes you suggested, but I don't know if they've been sent back to you.

@BillWagner BillWagner dismissed mairaw’s stale review March 2, 2020 21:24

maira has moved to the product team.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for the delay @balfourcraig

I've approved this and I'll :shipit: now.

@BillWagner BillWagner merged commit 3471c5b into dotnet:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants