Skip to content

Conversation

intern4tional
Copy link

Fixes a typo, the method is read only (get) but the line of text references set.

Summary

Describe your changes here.

Changes:

Gets or sets the name that identifies the service that this instance references.

To

Gets the name that identifies the service that this instance references.

For: https://docs.microsoft.com/en-us/dotnet/api/system.serviceprocess.servicecontroller.servicename?view=netframework-4.8

Fixes #Issue_Number (if available)

Fixes a typo, the method is read only (get) but the line of text references set.
@dotnet-bot dotnet-bot added this to the January 2020 milestone Jan 10, 2020
@mairaw mairaw added the ✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository label Jan 10, 2020
@mairaw
Copy link
Contributor

mairaw commented Jan 10, 2020

Thanks for your PR @intern4tional. The signature for that method changed in a couple of versions of .NET Core (1.0 and 1.1) but that API has getter and setter in most platforms and current versions. There's a bug fix in progress to display the right signature for the version selected.

https://github.com/dotnet/dotnet-api-docs/blob/master/xml/System.ServiceProcess/ServiceController.xml#L1114
https://github.com/dotnet/dotnet-api-docs/blob/master/xml/System.ServiceProcess/ServiceController.xml#L1120

One thing we could though is to mention in the remarks the specific versions of .NET Core that only had a getter. Thoughts?

@intern4tional
Copy link
Author

@mairaw thanks for the response; as there is a bug fix in work to display the proper version, I'll drop this PR and wait for that.

@mairaw
Copy link
Contributor

mairaw commented Jan 10, 2020

Ok, thanks @intern4tional!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants