Skip to content

Make note on change from previous behavior #3766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 31, 2020
Merged

Make note on change from previous behavior #3766

merged 8 commits into from
Jan 31, 2020

Conversation

monoclex
Copy link
Contributor

@monoclex monoclex commented Jan 12, 2020 •
edited
Loading

Summary

Added a remark noting a difference in net core 3 behavior for Try/Parse on Double & Float.

Should adhere #27898

@dotnet-bot dotnet-bot added this to the January 2020 milestone Jan 12, 2020
@mairaw mairaw added the ✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository label Jan 28, 2020
@mairaw mairaw requested a review from tannergooding January 28, 2020 08:07
@mairaw
Copy link
Contributor

mairaw commented Jan 28, 2020

Thanks for your contribution @SirJosh3917. @tannergooding can you please review this? /cc @gewarren since this is related to breaking changes

Wondering if the text here should be more similar to what we have in the breaking changes doc:
https://docs.microsoft.com/en-us/dotnet/core/compatibility/2.2-3.1#floating-point-formatting-and-parsing-behavior-changed

@mairaw mairaw requested a review from gewarren January 28, 2020 08:10
tannergooding
tannergooding reviewed Jan 28, 2020
View reviewed changes
gewarren
gewarren reviewed Jan 30, 2020
View reviewed changes
SirJosh3917 and others added 3 commits January 30, 2020 16:32
@gewarren
Tweak the description of System.Double
d9c4d8d 
Credits to @gewarren

Co-Authored-By: Genevieve Warren <[email protected]>
Remove accidental modifications to closing tags of markdown xref elem…
2c15372 
…ents.
Correct accidental formatting change
08240d6 
Misplaced an opening CDATA on a newline, whereas the current style appears to have it stay on the same line.
gewarren
gewarren reviewed Jan 30, 2020
View reviewed changes
gewarren
gewarren reviewed Jan 30, 2020
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only seen %2A being necessary for method overloads and sometimes for properties. And these are fields.

@gewarren
Apply suggestions from code review
81f02b0 
Co-Authored-By: Genevieve Warren <[email protected]>
gewarren
gewarren approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg!

@gewarren gewarren merged commit a0533bb into dotnet:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannergooding tannergooding tannergooding left review comments

@gewarren gewarren gewarren approved these changes

Assignees

@monoclex monoclex

Labels
✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository
Projects
None yet
Milestone
January 2020
Development

Successfully merging this pull request may close these issues.
5 participants
@monoclex @mairaw @tannergooding @gewarren @dotnet-bot